http://themeshaper.com/forums/ Help In Shaping WordPress Themes en Wed, 22 May 2013 09:56:16 +0000 http://themeshaper.com/forums/topic/bug-overriding-action-hook-calls#post-17515 Sun, 05 Dec 2010 04:33:21 +0000 Jonny Janiero 17515@http://themeshaper.com/forums/ <p>thanks for clearing that up Gene </p> http://themeshaper.com/forums/topic/bug-overriding-action-hook-calls#post-17513 Sun, 05 Dec 2010 04:07:01 +0000 em hr 17513@http://themeshaper.com/forums/ <p>Jonny,</p> <p>Yes, you have to override and then remove the action in a function that is hooked into init and then add again to change the priority parameter of the add_action hook. If you do not remove_action from the original priority the override will execute twice.</p> <p>-Gene </p> http://themeshaper.com/forums/topic/bug-overriding-action-hook-calls#post-17511 Sun, 05 Dec 2010 02:59:32 +0000 Jonny Janiero 17511@http://themeshaper.com/forums/ <p>@de_ce good find<br /> @em hr many thanks for the corrections.</p> <p>can i ask,<br /> for example...<br /> <pre><code>childtheme_override_blogtitle</code></pre> <p>without using the 'add_action' part, is there a way you can still specify its position within the override</p> <p>example...<br /> <pre><code>add_action(&#39;thematic_header&#39;,&#39;thematic_blogtitle&#39;,3);</code></pre> <p>or do you just have to use the override, then remove/add new action to change position.</p> <p>hope any of this makes sense? </p> http://themeshaper.com/forums/topic/bug-overriding-action-hook-calls#post-17479 Sat, 04 Dec 2010 03:31:22 +0000 em hr 17479@http://themeshaper.com/forums/ <p>Thanks for pointing this out. This has been corrected in the latest svn branch. </p> <p>You can download the latest stable development version here : <a href="http://developing.thematic4you.com/thematic-development-release/" rel="nofollow">http://developing.thematic4you.com/thematic-development-release/</a><br /> The sometimes experimental svn branch is here: <a href="http://code.google.com/p/thematic/source/checkout" rel="nofollow">http://code.google.com/p/thematic/source/checkout</a><br /> And bug reports are best made here: <a href="http://code.google.com/p/thematic/issues/list" rel="nofollow">http://code.google.com/p/thematic/issues/list</a> and in the forums ;)</p> <p>Thanks again,<br /> Gene </p> http://themeshaper.com/forums/topic/bug-overriding-action-hook-calls#post-17458 Fri, 03 Dec 2010 17:56:35 +0000 de_ce 17458@http://themeshaper.com/forums/ <p>There are many actions hooks that are not called if a ovverriding function in a child theme is used.</p> <p>ex:</p> <p><code><br /> // Create the blog description<br /> // In the header div<br /> if (function_exists('childtheme_override_blogdescription')) {<br /> function thematic_blogdescription() {<br /> childtheme_override_blogdescription();<br /> }<br /> } else {<br /> function thematic_blogdescription() {<br /> $blogdesc = '"blog-description"&gt;' . get_bloginfo('description');<br /> if (is_home() || is_front_page()) {<br /> echo "\t\t&lt;h1 id=$blogdesc&lt;/h1&gt;\n\n";<br /> } else {<br /> echo "\t\t&lt;div id=$blogdesc&lt;/div&gt;\n\n";<br /> }<br /> }<br /> add_action('thematic_header','thematic_blogdescription',5);<br /> }<br /> </code></p> <p>The action hook is called before the end of the if clause. It's kinda unintuitive to make a override function and call an action for the default function after it.</p> <p>Ex:</p> <p><code><br /> function childtheme_override_blogdescription() { ?&gt;<br /> &lt;p&gt;&lt;?php get_bloginfo('description'); ?&gt;&lt;/p&gt;<br /> &lt;?php<br /> }<br /> add_action('thematic_header','thematic_blogdescription',5);<br /> </code></p> <p>For some functions, the hooks are calld, but for other aren't. It's messy. A consitent rule would be nice. </p>