ThemeShaper Forums

Help In Shaping WordPress Themes

Register or log in:

Username:
Password:

Remember me

ThemeShaper Forums » Thematic

1. 

   fwunder
   Member

   OK, I know I'm a bit obsessed, but I've been spending a day or so learning Compass and SASS (which rocks, BTW) and my self imposed exile was to:

   1) Create an easily modified Holy Grail 3 column fluid/fixed layout with equal height columns in Compass SASS. Done! ==> http://grafiks101.com/holy-grail/ OK, that was fun.

   2) Quickly create a thematic site using the same code. Done! ==> http://grafiks101.com/dev/ Really, that was *a lot* easier than I though it would be and a *whole* lot easier than the brute force approach I took the first time. Pretty much a drop in replacement of css.

   Going forward, I now want to clean it up a bit. I seem to have a case of divitis. I really don't need "container" or even "main" for that matter. I'm really not sure how to properly dispose of them and what damage I might cause with brute force. Can I, should I do it or leave well enough alone?

   I should also say, that this wasn't just an exercise. I had a [wordpress] project which required a pixel perfect 3 column layout to a "designed to the fold" print layout. The Holy Grail 3 column layout was exactly what I needed and Thematic made it possible. Now I would like to streamline the process for the next time...

   Thanks!

   Posted 1 year ago #
2. 

   fwunder
   Member

   Never mind, I think. Been doing some reading and it seems it would not be a good idea to remove container or main divs. I've just emptied them instead in css. Am wondering if there is any SEO implication to divs with no spec. Hmmm.

   Posted 1 year ago #
3. 

   helgatheviking
   Moderator

   well #main is in header.php and #container is in index.php and its cousin-templates. so you couldn't really do it as a child theme unless you wanted to create your own version of all those templates. and at that point, you may as well fork thematic.

   Posted 1 year ago #
4. 

   fwunder
   Member

   Yeah, thanks. Doesn't seem necessary. I just kinda got obsessed with cleaning up my code. Works great as is.

   Thanks again.

   Posted 1 year ago #
5. 

   ScottNix
   Member

   "wondering if there is any SEO implication to divs with no spec".

   Nope, while a well structured page is important, a div doesn't mean anything, it would be exactly the same as an empty span tag, it has no real structural meaning, like an h1 or newer HTML5 tags. Sooooo many pages have what could be deemed extra markup. Now if you had a few empty <h1>'s laying around, maybe? But probably not. ;P

   If you wanted clean code there are a bunch of other things you can do to still, like combine the drop down scripts and move them to the footer, move jquery script also to the footer, remove the link rel edituri and wlwmanifest because I have yet to see them used for anything, remove the index, follow on main pages, because it is after all the friggin default.

   Posted 1 year ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.