We need your feedback « ThemeShaper Forums

ThemeShaper Forums » Thematic

[closed]

We need your feedback

(25 posts)

Started 3 years ago by Chris
Latest reply from Florent
This topic is not a support question

Chris
Moderator

Hi,

I'm working on some new code to speed up Thematic.

It would be great if you could checkout SVN version r549, install it on a live server, go to WP-Admin / Appearance / Thematic Options and hit 'Create Definitions'.

Please report the displayed status and if a directory 'settings' was created under your child theme's directory and if a file 'definitions.php' was created in this new directory.

The new code and some additional changes are already running on my blog. With the additional changes the 'definitions.php' is loaded and BLOGINFO_NAME is used instead of calling bloginfo('name') or get_bloginfo('name').

Depending on your feedback I'll extend the 'definitions.php' to cover all blog_info() calls.

Thanks!

Chris

Posted 3 years ago #
amygail
Member

hey Chris, I'd love to help - but I've never gotten a grasp on working with svn (ok - I admit it - I haven't taken the time to figure it out.)

Any chance you can provide us with a zip (or a clue;-)

thanks
a

Posted 3 years ago #
Chris
Moderator

Hey Amy,

as long as you're running a Windows machine you can try this one: How to get the latest SVN copy of Thematic? ;)

Let me know if this works .. if not I'll provide a ZIP on my blog.

Thanks!!!!

Chris

Posted 3 years ago #
amygail
Member

Chris - I'm a MAC! ;-)
I need to figure this (svn) out anyway - I'm pretty sure I can do it with Coda -I'll give it a shot

Posted 3 years ago #
Chris
Moderator

*sigh* .. and I want to be a MAC! ;)

Ok .. will be back in a couple of minutes with a link .. just in case.

Posted 3 years ago #
amygail
Member

yep - it was easy - I just needed to be motivated - I'll let you know what I find out.
a

Posted 3 years ago #
Chris
Moderator

The just in case link: Thematic revision 549

Posted 3 years ago #
amygail
Member

OK, PC - I've uploaded the new files.

Went to Thematic Options and hit "create definitions" and got "Thematic definitions created".

My childtheme still seems to be working (as much as it was anyway - still a WIP)

I'm not seeing a new directory anywhere (I'm looking in my child theme as well as Themeatic)

if it means anything -wp_enqueue_script('tools', get_bloginfo('stylesheet_directory') . '/js/jquery.tools.min.js', array('jquery'));

still works.

I can send a link if you like - it will pain me though 'cause it's still in progress

Posted 3 years ago #
Chris
Moderator

I hate it .. second test fails .. the directory should be right under the child theme's directory.

Have you tried the svn copy on thebassplayersgirl.com?

Posted 3 years ago #
amygail
Member

no - that site's as neglected as it looks...

The site I'm working on is http://burntsugarindex.com/sugar/

I'm still working on it, it's a mess - As far as I know it only works on firefox and safari on a mac

alot of custom templates -this is one page that's not hacked up
http://burntsugarindex.com/sugar/about-the-band/

Posted 3 years ago #
Chris
Moderator

:) .. directory and file are there!

Posted 3 years ago #
amygail
Member

OH - cool - I wander why I'm not seeing it...

So - does this mean I'll need to change anything as far as my child theme

- eg...
wp_enqueue_script('tools', get_bloginfo('stylesheet_directory') . '/js/jquery.tools.min.js', array('jquery'));

Posted 3 years ago #
amygail
Member

OH - I see it now drrrr sorry about that

Posted 3 years ago #
Chris
Moderator

No problem ..

At the moment there's no need to change your child theme. I still don't know where I end with this code. Need to do some speed tests on my blog with several code options.

Nothing to worry about for the moment and the future. We won't break any child themes with our code changes. And we will provide a 'Best Practice Guide' to upgrade a child theme to use this new functionality.

Thanks for your help, MAC! :)

Posted 3 years ago #
amygail
Member

Hey PC, Always happy to reach out to the other side ;-)

I don't know where this is going either (obviously) - but I like the idea of an options panel that actually creates files rather than just adding tables to the DB.

I hate to think of all the times that I've had to spend recreating options settings.

I know you're working on a config plugin that "will allow new users to configure Thematic without creating a functions.php"

If it were to actually create a file (like WP's config file) - that would be kind of ground breaking -at least as far as I'm concerned

Posted 3 years ago #
Chris
Moderator

Update:

My blog is running now without calling get_bloginfo() or bloginfo()

:)

It would be great if we can find some more volunteers that want to test the above mentioned code.

Chris

Posted 3 years ago #
LegendsCrazy
Member
I'll test it for you Chris. You've been a great help to me a number of times, it's the least I can do. I just downloaded the zip and am uploading now. I went to thematic options and hit the create definitions button. A new folder was placed in my child theme folder called settings and inside the settings folder was definitions.php Easy Peasy. Let me know if there is anything else you need.

Cheers!

Edit: Oh and this was in definitions.php
```
<?php
DEFINE('BLOGINFO_NAME', 'LegendsCrazy.net');
?>
```
Posted 3 years ago #
dannydamnboy
Member
Hey Chris! Same as above for me:
```
<?php
DEFINE('BLOGINFO_NAME', 'Altamente Decorativo');
?>
```
Posted 3 years ago #
Chris
Moderator

Thanks a lot!

Sounds perfect .. already changed the content of definitions.php. It'll now create an array of everything that can be called by get_bloginfo() .. reduced the size of the new function thm_bloginfo dramatically :)

I'll take one or two more days for testing before I copy the version that's running on my blog to the SVN repository.

Posted 3 years ago #
Chris
Moderator

Btw.: What do you think about having a single function call in your functions.php creating a widgetized area in one of the Thematic hooks?

Posted 3 years ago #
amygail
Member

"Btw.: What do you think about having a single function call in your functions.php creating a widgetized area in one of the Thematic hooks? "

I'm sure a lot of folks will find that helpful

Posted 3 years ago #
Krusty Ruffle
Member

I know this is a bit late, but when using this with WPMU it will overwrite the definitions file whenever a different blog hits the 'create definitions' button... and there is also no way to tell if a blog has created definitions or not, or which blog created the definitions last.

The blogs do still get the right name though...

also, I'm using revision 550.

Hope that's helpfull :^)

Posted 3 years ago #
Chris
Moderator

*damn* .. sorry .. I'll check my latest local version against WPMU.

Thanks for your help!

Chris

Posted 3 years ago #
Krusty Ruffle
Member

Just hoping to help. I think this is a great idea and am looking forward to seeing it when it's fully implemented. 'Till then I'm more than willing to try to help, though I'm not real strong in the coding skills area...

Posted 3 years ago #
Florent
Member

Hi Chris,

The definitions file is created fine on my local machine.

I would like to point out a tiny glitch: there is an extra line feed after the PHP closing tag in the 'settings/definitions.php' file. It doesn't look like it's causing any trouble, but it is probably injecting whitespace somewhere in the output, so it should be removed.

And, instead of just removing that line feed, I suggest you consider removing the PHP closing tag altogether, as it is completely optional. This prevents trailing whitespace from being injected into HTML output.

This recommendation is part of the Zend Framework coding standard (see http://framework.zend.com/wiki/display/ZFDEV/PHP+Coding+Standard+(draft)#PHPCodingStandard(draft)-General), and it would be cool to follow it in Thematic.

Best,

Florent

Posted 3 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.